Merge lp://staging/~sam-sgrs/ubuntu-system-settings-online-accounts/ubuntu-system-settings-online-accounts_1553771 into lp://staging/ubuntu-system-settings-online-accounts
Proposed by
Sam Segers
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~sam-sgrs/ubuntu-system-settings-online-accounts/ubuntu-system-settings-online-accounts_1553771 |
| Merge into: | lp://staging/ubuntu-system-settings-online-accounts |
| Diff against target: |
12 lines (+1/-1) 1 file modified
plugins/module/OAuth.qml (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~sam-sgrs/ubuntu-system-settings-online-accounts/ubuntu-system-settings-online-accounts_1553771 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Mardegan (community) | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 332. By Sam Segers
-
Add error message to the output of onAuthenticatio
nError - 331. By Launchpad Translations on behalf of online-accounts
-
Launchpad automatic translations update.
- 330. By Launchpad Translations on behalf of online-accounts
-
Launchpad automatic translations update.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Sorry Sam, for some reason I completely missed this merge request.
Looks good, just please remove the space before the ")", to be consistent with the rest of the code.