Merge lp://staging/~salgado/offspring/disable-subscription-for-private-projects into lp://staging/~linaro-automation/offspring/private-builds

Proposed by Guilherme Salgado
Status: Merged
Approved by: James Tunnicliffe
Approved revision: no longer in the source branch.
Merged at revision: 69
Proposed branch: lp://staging/~salgado/offspring/disable-subscription-for-private-projects
Merge into: lp://staging/~linaro-automation/offspring/private-builds
Prerequisite: lp://staging/~salgado/offspring/more-piston-handlers
Diff against target: 116 lines (+52/-1)
4 files modified
lib/offspring/master/models.py (+1/-0)
lib/offspring/master/notifications.py (+3/-0)
lib/offspring/master/tests.py (+39/-0)
lib/offspring/web/templates/queuemanager/project_details.html (+9/-1)
To merge this branch: bzr merge lp://staging/~salgado/offspring/disable-subscription-for-private-projects
Reviewer Review Type Date Requested Status
Linaro Infrastructure Pending
Review via email: mp+79606@code.staging.launchpad.net

Description of the change

This branch disables the ability to subscribe to notifications of private projects as well as the sending of notifications about private projects

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

On Mon, 17 Oct 2011 19:43:31 -0000, Guilherme Salgado <email address hidden> wrote:
> Guilherme Salgado has proposed merging lp:~salgado/offspring/disable-subscription-for-private-projects into lp:~linaro-infrastructure/offspring/private-builds with lp:~salgado/offspring/more-piston-handlers as a prerequisite.
>
> Requested reviews:
> Linaro Infrastructure (linaro-infrastructure)
>
> For more details, see:
> https://code.launchpad.net/~salgado/offspring/disable-subscription-for-private-projects/+merge/79606
>
> This branch disables the ability to subscribe to notifications of
> private projects as well as the sending of notifications about private
> projects

Hi,

What's the rationale for this one?

Thanks,

James

Revision history for this message
James Tunnicliffe (dooferlad) wrote :

On 17 October 2011 21:34, James Westby <email address hidden> wrote:
> What's the rationale for this one?

The idea is to close the loop on:

1. Project is public
2. User subscribes to project
3. Project is made private
4. User is still subscribed to project, doesn't matter if they are a
member of the private projects team or not.

This is an initial implementation with a view to adding subscriptions
back to private projects if they are needed later.

--
James Tunnicliffe

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches