Merge lp://staging/~rye/python-oops-tools/oopsloader-update-date-when-needed into lp://staging/python-oops-tools

Proposed by Roman Yepishev
Status: Merged
Approved by: Robert Collins
Approved revision: 5
Merged at revision: 5
Proposed branch: lp://staging/~rye/python-oops-tools/oopsloader-update-date-when-needed
Merge into: lp://staging/python-oops-tools
Diff against target: 20 lines (+6/-4)
1 file modified
src/oopstools/oops/dboopsloader.py (+6/-4)
To merge this branch: bzr merge lp://staging/~rye/python-oops-tools/oopsloader-update-date-when-needed
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+80079@code.staging.launchpad.net

Commit message

Tune dboopsloader to avoid pointless commits to the last-processed date marker.

Description of the change

Tune dboopsloader to avoid pointless commits to the last-processed date marker.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

.save does not do what you think it does :)

You need the .save, but what you want to avoid is the commits; that means:
 - taking the ORM out of autocommit mode
 - explicitly doing a commit (I suggest one every 5 seconds work)

review: Needs Fixing
Revision history for this message
Robert Collins (lifeless) wrote :

Oh bah, I see, I misread. So I'm going to +1 this instead, but I'll note that there is an equal performance win waiting if we move out of autocommit mode.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: