Merge lp://staging/~rvb/txlongpoll/change-bin-txlongpoll into lp://staging/txlongpoll

Proposed by Raphaël Badin
Status: Merged
Approved by: Julian Edwards
Approved revision: 62
Merged at revision: 62
Proposed branch: lp://staging/~rvb/txlongpoll/change-bin-txlongpoll
Merge into: lp://staging/txlongpoll
Diff against target: 35 lines (+3/-3)
3 files modified
Makefile (+1/-1)
README (+1/-1)
buildout.cfg (+1/-1)
To merge this branch: bzr merge lp://staging/~rvb/txlongpoll/change-bin-txlongpoll
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+77134@code.staging.launchpad.net

Commit message

Generated script is named txlongpoll.

Description of the change

This branch changes the name of the binary generated from twistd to txlongpoll.

To post a comment you must log in.
62. By Raphaël Badin

Rename bin/twistd to bin/txlongpoll.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Perfect!

review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

This is just a rename; txlongpoll is now a synonym for twistd. I thought the txlongpoll script should encapsulate calling amqp-longpoll too.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Tuesday 27 September 2011 12:14:23 you wrote:
> This is just a rename; txlongpoll is now a synonym for twistd. I thought
> the txlongpoll script should encapsulate calling amqp-longpoll too.

It should, yes. We need to generate a new script for that.

However, the primary reason for doing this is so that the binary name doesn't
clash with the one already in LP's buildout.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches