MAAS

Merge lp://staging/~rvb/maas/lp-1313550 into lp://staging/~maas-committers/maas/trunk

  1. lp-1313550
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 4028
Proposed branch: lp://staging/~rvb/maas/lp-1313550
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 158 lines (+65/-16)
2 files modified
src/provisioningserver/import_images/tests/test_uec2roottar.py (+37/-1)
src/provisioningserver/import_images/uec2roottar.py (+28/-15)
To merge this branch: bzr merge lp://staging/~rvb/maas/lp-1313550
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+262314@code.staging.launchpad.net

Commit message

Fix bug 1313550: use xattrs options if tar supports them.

Description of the change

This is based on Scott's https://code.launchpad.net/~smoser/maas/lp-1313550/+merge/261981. I've only refactored the code a tad and added the required unit tests.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good. The self.patch calls could probably be rewritten without the "magic string", such as:

    self.patch(uec2roottar.check_output)

(but this was recently landed in 1.9, so if there is a chance this will be back-ported to 1.8, let's leave it as-is.)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.