Merge lp://staging/~rvb/maas/hostname-bug-1155607 into lp://staging/~maas-committers/maas/trunk
Proposed by
Raphaël Badin
| Status: | Merged |
|---|---|
| Approved by: | Raphaël Badin |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1620 |
| Proposed branch: | lp://staging/~rvb/maas/hostname-bug-1155607 |
| Merge into: | lp://staging/~maas-committers/maas/trunk |
| Diff against target: |
63 lines (+34/-1) 2 files modified
src/maasserver/node_constraint_filter_forms.py (+14/-1) src/maasserver/tests/test_node_constraint_filter_forms.py (+20/-0) |
| To merge this branch: | bzr merge lp://staging/~rvb/maas/hostname-bug-1155607 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeroen T. Vermeulen (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Change AcquireForm so that it matches hostnames against nodes' FQDNs.
Description of the change
This branch fixes the AcquireForm so that it will use the nodes' FQDNs (built from the hostname of the node and the domain part from the nodegroup) to match against the given hostname. With that fix, one will be able to acquire a node using it's FQDN (see the bug's description).
Maybe we could go one step further and remove the ".local" part from the hostname altogether. But I looked briefly into this and it showed that it's very likely a huge rabbit hole. The fix from this branch is rather focused I think this is the best option for now.
This was pre-imp'ed with Gavin.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yes, removing .local sounds like a dangerous rabbit hole, given the amount of compatibility trickery we have in the hostnames. :-)