Merge lp://staging/~rvb/launchpad/ppa-copy-notifications-javascript into lp://staging/launchpad

Proposed by Raphaël Badin
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 14665
Proposed branch: lp://staging/~rvb/launchpad/ppa-copy-notifications-javascript
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~rvb/launchpad/ppa-copy-notifications-template
Diff against target: 394 lines (+331/-5)
5 files modified
lib/lp/soyuz/browser/tests/test_archive_packages.py (+2/-2)
lib/lp/soyuz/javascript/archive-packages.js (+130/-0)
lib/lp/soyuz/javascript/tests/test_archive-packages.html (+53/-0)
lib/lp/soyuz/javascript/tests/test_archive-packages.js (+124/-0)
lib/lp/soyuz/templates/archive-packages.pt (+22/-3)
To merge this branch: bzr merge lp://staging/~rvb/launchpad/ppa-copy-notifications-javascript
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+87763@code.staging.launchpad.net

Commit message

[r=sinzui][bug=575450] Display the job notifications on a ppa's +packages page (javascript code).

Description of the change

This branch is the javascript part of a work to show the job notifications on a ppa's +packages page. This branch adds a new YUI widget to control the interaction with the notifications that can be cancelled via an ajax call to the api.

= Tests =
lib/lp/soyuz/javascript/tests/test_archive-packages.html

= Q/A =
Copy a few packages into a ppa making sure that some copy will fail. The ppa's +package page should display the related notifications along with a "Remove notification" link that should allow one to remove the notification's information.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you for this branch. I was unaware of the <script type="text/x-template"> technique. Your branch was educational for me. I think this is good to merge.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.