Merge lp://staging/~rvb/launchpad/fix-package-diff-equal-versions into lp://staging/launchpad

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 12834
Proposed branch: lp://staging/~rvb/launchpad/fix-package-diff-equal-versions
Merge into: lp://staging/launchpad
Diff against target: 59 lines (+26/-1)
3 files modified
lib/lp/registry/browser/distroseriesdifference.py (+5/-0)
lib/lp/registry/browser/tests/test_distroseriesdifference_views.py (+20/-0)
lib/lp/registry/templates/distroseriesdifference-listing-extra.pt (+1/-1)
To merge this branch: bzr merge lp://staging/~rvb/launchpad/fix-package-diff-equal-versions
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Review via email: mp+57686@code.staging.launchpad.net

Commit message

[r=jcsackett][bug=760691] Fix the UI of +localpackagediffs to prevent the display of a parent package diff when no parent package diff can exist (that is if base_version==parent_source_version).

Description of the change

This branch fixes the UI on the +localpackagediffs page so that the parent package diff is not displayed if base_version==parent_source_version.

= Test =
./bin/test -cvv test_distroseriesdifference_views test_do_not_display_parent_diff

= QA =
- On the page:
    https://dogfood.launchpad.net/ubuntu/natty/+localpackagediffs
- Open the row for 'abakus'.
- Only one package diff line should be there. No line should go like this "0.91-1 to Sid version: 0.91-1".

To post a comment you must log in.
Revision history for this message
j.c.sackett (jcsackett) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.