Launchpad itself

Merge lp://staging/~rvb/launchpad/branches-timeout-bug-827935-4 into lp://staging/launchpad

branches-timeout-bug-827935-4
Merge into devel

Proposed by Raphaël Badin on 2011-11-04

Status:

Merged

Approved by:

Raphaël Badin on 2011-11-04

Approved revision:

no longer in the source branch.

Merged at revision:

14258

Proposed branch:

lp://staging/~rvb/launchpad/branches-timeout-bug-827935-4

Merge into:

lp://staging/launchpad

Prerequisite:

lp://staging/~rvb/launchpad/branches-timeout-bug-827935-3

Diff against target:

58 lines (+3/-16)

2 files modified

lib/lp/code/browser/branchlisting.py (+1/-8)
lib/lp/code/browser/tests/test_branchlisting.py (+2/-8)

To merge this branch:

bzr merge lp://staging/~rvb/launchpad/branches-timeout-bug-827935-4

Related bugs:

Bug #827935: Person:+branches timeouts

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Abel Deuring (community)	code	2011-11-04	Approve on 2011-11-04
Review via email: mp+81290@code.staging.launchpad.net

Commit message

[incr] [r=adeuring][bug=827935] Always display the link to the "Active reviews" page on the branch listing page.

Description of the change

Another simplification to the simplified menu (which is protected by a FF) on https://code.launchpad.net/~me. Checking for the presence of active reviews (to choose whether or not we want to display a link) leads to this kind of request: http://paste.ubuntu.com/728236/ which takes 1s-2s on ~https://code.launchpad.net/~ubuntu-branches. You might think that the duplication of the block http://paste.ubuntu.com/728238/ is responsible for the bad performance but that's not the case; the problem is the enormous number of branches satisfying "Branch.transitively_private = FALSE" (300k on ~ubuntu-branches). The easy solution is to always display the link to the "Active reviews" page.