Go Windows Azure Client Library

Merge lp://staging/~rvb/gwacl/restructure-hosted-service into lp://staging/gwacl

  1. restructure-hosted-service
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 175
Merged at revision: 175
Proposed branch: lp://staging/~rvb/gwacl/restructure-hosted-service
Merge into: lp://staging/gwacl
Diff against target: 126 lines (+72/-5)
3 files modified
management_test.go (+3/-2)
xmlobjects.go (+11/-3)
xmlobjects_test.go (+58/-0)
To merge this branch: bzr merge lp://staging/~rvb/gwacl/restructure-hosted-service
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+173974@code.staging.launchpad.net

Commit message

Restructure Hosted Service.

Description of the change

Change the HostedService object so that it is effectively a HostedServiceDescriptor plus the list of deployments (a HostedService now embeds a HostedServiceDescriptor).

This is useful to get a HostedServiceDescriptor out of a HostedService (and we retrieve a HostedService when we get an individual Service).

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Cool. Is Azure's HostedService definition a superset of HostedServiceDescriptor, i.e. there are no fields in HostedServiceDescriptor that are not in HostedService?

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

> Cool. Is Azure's HostedService definition a superset of
> HostedServiceDescriptor, i.e. there are no fields in HostedServiceDescriptor
> that are not in HostedService?

Yes, the API does not say so explicitly but that's what the examples show. Actually, I'm starting to wonder if we should not get rid of HostedServiceDescriptor altogether and simple return a HostedService with its Deployment field empty where we return a HostedServiceDescriptor today.

Revision history for this message
Gavin Panella (allenap) wrote :

> Actually, I'm starting to wonder if we should not get rid of
> HostedServiceDescriptor altogether and simple return a HostedService
> with its Deployment field empty where we return a
> HostedServiceDescriptor today.

I think it's safer to keep them separate. It helps prevent us
confusing a HostedServiceDescriptor with a HostedService that has no
deployments, and vice-versa.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: