Go Windows Azure Client Library

Merge lp://staging/~rvb/gwacl/listhostedservices-2 into lp://staging/gwacl

  1. listhostedservices-2
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 164
Merged at revision: 162
Proposed branch: lp://staging/~rvb/gwacl/listhostedservices-2
Merge into: lp://staging/gwacl
Diff against target: 132 lines (+86/-4)
2 files modified
management.go (+25/-0)
management_test.go (+61/-4)
To merge this branch: bzr merge lp://staging/~rvb/gwacl/listhostedservices-2
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+172989@code.staging.launchpad.net

Commit message

Add ListSpecificHostedServices.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Looks good.

[1]

+    c.Assert(len(recordedRequests), Equals, 1)

There's a HasLen checker:

    c.Assert(recordedRequests, HasLen, 1)

Here and one other place.

review: Approve
lp://staging/~rvb/gwacl/listhostedservices-2 updated
164. By Raphaël Badin

Review fixes.

Revision history for this message
Raphaël Badin (rvb) wrote :

> Looks good.
>
>
> [1]
>
> +    c.Assert(len(recordedRequests), Equals, 1)
>
> There's a HasLen checker:
>
>    c.Assert(recordedRequests, HasLen, 1)
>
> Here and one other place.

Fixed, thanks for the review!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: