Go Windows Azure Client Library

Merge lp://staging/~rvb/gwacl/ignore-404 into lp://staging/gwacl

  1. ignore-404
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 209
Merged at revision: 208
Proposed branch: lp://staging/~rvb/gwacl/ignore-404
Merge into: lp://staging/gwacl
Diff against target: 82 lines (+16/-13)
2 files modified
storage_base.go (+5/-0)
storage_base_test.go (+11/-13)
To merge this branch: bzr merge lp://staging/~rvb/gwacl/ignore-404
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+177842@code.staging.launchpad.net

Commit message

Ignore 404 errors in DeleteContainer().

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks good. Minor, but:

TestDeleteNotExistantContainerDoesNotFail

It's spelled "Existent".

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

> Looks good. Minor, but:
>
> TestDeleteNotExistantContainerDoesNotFail
>
> It's spelled "Existent".

Fixed (here and in a couple of other places as well).

Thanks for the review!

Revision history for this message
Julian Edwards (julian-edwards) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: