Unity Control Center

Merge lp://staging/~rs2009/unity-control-center/fix-for-groovy-minor into lp://staging/unity-control-center

  1. fix-for-groovy-minor
  2. Merge into trunk
Proposed by Rudra Saraswat
Status: Approved
Approved by: Sebastien Bacher
Approved revision: 12931
Proposed branch: lp://staging/~rs2009/unity-control-center/fix-for-groovy-minor
Merge into: lp://staging/unity-control-center
Diff against target: 25 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp://staging/~rs2009/unity-control-center/fix-for-groovy-minor
Reviewer Review Type Date Requested Status
Khurshid Alam (community) Approve
Sebastien Bacher Pending
Review via email: mp+394230@code.staging.launchpad.net

Commit message

Update Groovy text in debian/rules

To post a comment you must log in.
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Stderr only for debugging purpose. It does increase the logs in syslog. We don't want that.

Reply
lp://staging/~rs2009/unity-control-center/fix-for-groovy-minor updated
12930. By Rudra Saraswat

Redirect to stdout instead of stderr in update-from-gsd.sh

Revision history for this message
Rudra Saraswat (rs2009) wrote :

Khurshid, I've reverted back to stdout.

Reply
lp://staging/~rs2009/unity-control-center/fix-for-groovy-minor updated
12931. By Rudra Saraswat

Update debian/changelog

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

Approved. But it seems there is no groovy branch for u-c-c. And merge request should happen against this branch. For SRU a debdiff can also work here. Requesting @seb128 for review.

review: Approve
Reply
Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

@rs2009 Can you also assign https://launchpad.net/~seb128 for revirew ?

Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, the change is correct but if you want a stable update you need a bug following the SRU template (https://wiki.ubuntu.com/StableReleaseUpdates for details)

It would also probably make sense to do an upload to the hirsute serie now

Reply

Unmerged revisions

12931. By Rudra Saraswat

Update debian/changelog

12930. By Rudra Saraswat

Redirect to stdout instead of stderr in update-from-gsd.sh

12929. By Rudra Saraswat

* Update logo for groovy
* Echo to stderr, not stdout in die() (update-from-gsd.sh)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches