Merge lp://staging/~rperier/unity/command-lens-switching into lp://staging/unity

Code looks good (one indentation on line 13 a part).

Thanks a lot!

On tests:

50 +

Please, remove this empty space

49 + self.assertThat(self.dash.visible, Eventually(Equals(False)))

Probably it's better to check this instead:
self.assertThat(self.dash.active_lens, Eventually(Equals('home.lens')))

Also, please add that assert statement also in the test_can_go_from_dash_to_command_lens test.

Updated, is it correct now ?

Hi! I actually think that Marco had something different in mind ;)

So, it was good that there were 2 different tests before, so if you could revert to the previous state it was good.

The thing what we wanted to be changed is using self.assertThat(self.dash.active_lens, Eventually(Equals('home.lens'))) instead of self.assertThat(self.dash.visible, Eventually(Equals(False))) in the test_can_go_from_command_lens_to_dash test. Since this way we'll be checking that when pressing 'Super', that the home lens of the dash will be opened, not some other lens.

By 'Also, please add that assert statement also in the test_can_go_from_dash_to_command_lens test.' Marco probably meant for you to modify the previous test of test_can_go_from_dash_to_command_lens to also check if the command lens is opened. So, a check for self.assertThat(self.dash.active_lens, Eventually(Equals('commands.lens'))) . e.g.

    def test_can_go_from_dash_to_command_lens(self):
        """Switch to command lens without closing the dash."""
        self.dash.ensure_visible()
        self.dash.reveal_command_lens()
        self.assertThat(self.dash.visible, Eventually(Equals(False)))
        self.assertThat(self.dash.active_lens, Eventually(Equals('commands.lens')))
        # Here we make sure that the dash is closed and the commans lens opened

    def test_can_go_from_command_lens_to_dash(self):
        self.dash.reveal_command_lens()
        self.dash.ensure_visible()
        self.assertThat(self.dash.visible, Eventually(Equals(True)))
        self.assertThat(self.dash.active_lens, Eventually(Equals('home.lens')))
        # This way we check both if the dash is opened and the right lens

        # Remember about whitespaces!

Also, make sure you use the right identing. In python whitespaces are valid syntax elements, so make sure you use the same number of spaces as other blocks. Since I see you used tab-spaces, while we use only spaces for python autopilot tests.

Besides the testing, code and fix looks fine.

Romain? Any news on this? :)

Using this branch:
https://code.launchpad.net/~brandontschaefer/unity/lp.1108956-fix/+merge/156194