webbrowser-app

Merge lp://staging/~rpadovani/webbrowser-app/remember-height-width-destkop into lp://staging/webbrowser-app

  1. remember-height-width-destkop
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Rejected
Rejected by: Florian Boucault
Proposed branch: lp://staging/~rpadovani/webbrowser-app/remember-height-width-destkop
Merge into: lp://staging/webbrowser-app
Diff against target: 74 lines (+30/-0)
2 files modified
src/app/webbrowser/Browser.qml (+16/-0)
src/app/webbrowser/webbrowser-app.qml (+14/-0)
To merge this branch: bzr merge lp://staging/~rpadovani/webbrowser-app/remember-height-width-destkop
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+256004@code.staging.launchpad.net

Commit message

Remember position (x and y), height and width on desktop at restart

Description of the change

Remember position (x and y), height and width on desktop at restart.

When you click reset in settings, it reset height and width but not the position. Does it make sense? Should I reset all 4? (or no one of them)?

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:966
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1634/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2205
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/392
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/392
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/392/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/392
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1934
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2203/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19577

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1634/rebuild

review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

I think it would be ok to reset all 4 values.

This would need to be implemented for the webapp container as well, i.e. at BrowserWindow level (src/app/BrowserWindow.qml), and thus I guess it would make sense to store those values separately. The documentation for Qt.labs.settings isn’t really clear about that, so this would need to be tested: can we have two separate Settings object instances, each with a group of different properties, and have all of them written to the same file? If so, then we could have a generic Settings instance in BrowserWindow.qml for x, y, width and height, and the rest of the app-specific settings in Browser.qml.

lp://staging/~rpadovani/webbrowser-app/remember-height-width-destkop updated
967. By Riccardo Padovani

Reset also x and y size on reset settings

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

> I think it would be ok to reset all 4 values.

Done.

About Webapps, I thought about them, my doubt is: if we add a new settings object in the BrowserWindow.qml (and let's say it works) then how do we access it from Browser.qml to reset properties?

Maybe is better to create a new Settings object to WebApp.qml? (And maybe in future allow webapps to create settings)?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:967
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1691/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2450/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/448
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/448
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/448/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/448
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2127/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2448
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2448/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19922

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1691/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

Superseeded by https://code.launchpad.net/~fboucault/webbrowser-app/save_window_size/+merge/317467

Unmerged revisions

967. By Riccardo Padovani

Reset also x and y size on reset settings

966. By Riccardo Padovani

Remember height, width and position at next restart on desktop

965. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

964. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

963. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: