Ubuntu Notes app

Merge lp://staging/~rpadovani/reminders-app/1382730 into lp://staging/reminders-app

  1. 1382730
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: David Planella
Approved revision: 280
Merged at revision: 285
Proposed branch: lp://staging/~rpadovani/reminders-app/1382730
Merge into: lp://staging/reminders-app
Diff against target: 25 lines (+2/-2)
2 files modified
src/app/qml/components/PageWithBottomEdge.qml (+1/-1)
src/app/qml/ui/NotesPage.qml (+1/-1)
To merge this branch: bzr merge lp://staging/~rpadovani/reminders-app/1382730
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Michael Zanetti (community) Approve
Review via email: mp+238904@code.staging.launchpad.net

Commit message

Fixed #1382730 - Unable to create new notes

Description of the change

Fixed #1382730 - Unable to create new notes

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

cheers

review: Approve
Revision history for this message
David Planella (dpm) wrote :

This doesn't seem to fix it for me, the error comes on qml/components/PageWithBottomEdge.qml:

qml/components/PageWithBottomEdge.qml:114: ReferenceError: filter is not defined
                NotesStore.createNote("Untitled", filter);

review: Needs Fixing
Revision history for this message
David Planella (dpm) wrote :

LGTM now and it works, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:280
http://91.189.93.70:8080/job/reminders-app-ci/559/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1057
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1057/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/255

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/559/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches