Merge lp://staging/~roryj/wingpanel/match-gala-animations into lp://staging/~elementary-pantheon/wingpanel/trunk-0.3.x

Proposed by Rory
Status: Merged
Merged at revision: 197
Proposed branch: lp://staging/~roryj/wingpanel/match-gala-animations
Merge into: lp://staging/~elementary-pantheon/wingpanel/trunk-0.3.x
Diff against target: 263 lines (+139/-35)
1 file modified
src/Widgets/BasePanel.vala (+139/-35)
To merge this branch: bzr merge lp://staging/~roryj/wingpanel/match-gala-animations
Reviewer Review Type Date Requested Status
Tom Beckmann (community) Approve
Review via email: mp+232107@code.staging.launchpad.net

Commit message

Match gala animations better & optimizations.

Description of the change

Get current gala animation and change fade duration to match.

Optimizations: the panel alpha is now only updated once when a window state changes.

To post a comment you must log in.
167. By Rory

Quickly moving window between workspaces wouldn't update panel.

168. By Rory

When opening window, wait for geometry to change before updating.

169. By Rory

Fix panel occasionally not updating.

Revision history for this message
Rory (roryj) wrote :

This should be ready to be merged!

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Sorry for the long delay, there was much to do in the past few weeks :/

I added some general comments for things I noticed.

review: Needs Fixing
170. By Rory

Refactoring & fix bug #1365813.

Revision history for this message
Rory (roryj) wrote :

No problem, thanks for helping as always! ;)

Have made changes as suggested and fixed bug #1365813 as a bonus.

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

There are some oddities on my HiDPI system (awesome that you fixed this btw!!), still tracking those.
I don't have access to a second monitor right now, will get to one tomorrow or maybe this evening, are you sure monitor_workarea.x/y won't have to be multiplied by the scale_factor (only guessing here right now)? I think you're multiplying some of the values, but not all

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

So the easy (and obvious) fix is to multiply every monitor value with scale :)
You may want to do that before the if-block. One other thing you may want to check, you're connecting quite frequently to geometry-changed, but you only ever disconnect if a window fills the workarea. Is that correct?

171. By Rory

Multiply everything by scale_factor & multi-monitor improvements.

Revision history for this message
Rory (roryj) wrote :

OK, it now multiplies all the coords by scale_factor. I (very unfortunately) don't have multi-monitors at the moment so I would appreciate it if you could do some testing to check everything works.

Yes that is correct. From my testing, connecting to geometry-changed is the only way to get around the 'bugginess' of Wnck. However, it is only connected when a window is already being maximized, so it should only be connected for a very short time.

172. By Rory

Multi-monitor tweaks.

Revision history for this message
Rory (roryj) wrote :

Have managed to do some testing with dual monitors and it appears to be working fine.

How I wish wnck would have multi-monitor support!

173. By Rory

Update panel when fullscreen apps close.

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Again, sorry that it took so long. I did some testing and read through the code, everything looks great. (I made a slight change for the array though, no need to have it malloc'ed "int array[6]" works just as well here). Thanks a lot for the great branch :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: