Apport

Merge lp://staging/~roignac/apport/bugpattern-check_for_duplicates into lp://staging/~ubuntu-bugcontrol/apport/ubuntu-bugpatterns

bugpattern-check_for_duplicates
Merge into ubuntu-bugpatterns

Proposed by Vadim Rutkovsky on 2011-09-07

Status:	Merged
Merged at revision:	334
Proposed branch:	lp://staging/~roignac/apport/bugpattern-check_for_duplicates
Merge into:	lp://staging/~ubuntu-bugcontrol/apport/ubuntu-bugpatterns
Diff against target:	71 lines (+38/-13) 1 file modified test-local (+38/-13)
To merge this branch:	bzr merge lp://staging/~roignac/apport/bugpattern-check_for_duplicates
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Murray		2011-09-07	Approve on 2011-09-12
Review via email: mp+74391@code.staging.launchpad.net

Description of the change

test-local now checks that duplicate issues also match the pattern.
Maybe this should be optional?

lp://staging/~roignac/apport/bugpattern-check_for_duplicates updated on 2011-09-07

312. By Vadim Rutkovsky on 2011-09-07: Show correct bugnumber if any of duplicates didn't match the pattern
313. By Vadim Rutkovsky on 2011-09-07: Skip non apport-crash issues when checking for duplicates

Revision history for this message

Brian Murray (brian-murray) wrote on 2011-09-12:

This is great! I'm still playing with it now but thanks for doing this.

Revision history for this message

Brian Murray (brian-murray) wrote on 2011-09-12:

I'm leaving this as non-optional as I found the duplicate checking useful as it allowed me to expand a bug pattern. I did make some minor changes to your branch also.

I removed sys.exit from match_bug so it'll keep checking other duplicates.

Because the tags of a bug report are a list you don't really need to iterate over them.
if 'apport-crash' in bug.tags:

And using total_size wasn't really necessary. This was sufficient:
if bug.duplicates:

review: Approve