lp://staging/~rogpeppe/juju-core/simplify-watchers

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://staging/~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-07-16

Diff: 1115 lines (+258/-256)

13 files modified

state/machine.go (+2/-2)
state/machine_test.go (+10/-4)
state/service.go (+8/-8)
state/service_test.go (+24/-22)
state/state.go (+6/-6)
state/state_test.go (+9/-12)
state/unit.go (+6/-6)
state/unit_test.go (+9/-12)
state/watcher.go (+128/-116)
state/watcher/watcher.go (+39/-47)
state/watcher/watcher_test.go (+8/-15)
worker/machiner/machiner.go (+3/-2)
worker/provisioner/provisioner.go (+6/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

302. By Roger Peppe on 2012-07-16

state/eatcher: fix test

301. By Roger Peppe on 2012-07-16

state: make watchers use explicit stop channel

300. By Roger Peppe on 2012-07-16

start watcher simplification

299. By William Reade on 2012-07-14

reorder state watcher types

... so that service-related watchers are all together, and follow the usual
watcher-type; change-type; watcher-implementation convention.

No behaviour changes whatsoever; got an IRC LGTM from rogpeppe.

R=
CC=
https://codereview.appspot.com/6405043

298. By Roger Peppe on 2012-07-12

environs: add methods for opening and closing ports.

Also add a dummy implementation, and clean up dummy op
send semantics slightly.

R=niemeyer
CC=
https://codereview.appspot.com/6349097

297. By Dave Cheney on 2012-07-11

all: rename service => worker

As discussed in the 03/07/2012 team meeting, among a poor field of
candidates, worker(s) was the prefered name for the code that runs
inside an agent. eg, the Provisioner worker runs inside the
Provisioning agent.

note: also fixed a gofmt issue in state/ which had been bugging me.

R=niemeyer
CC=
https://codereview.appspot.com/6345084

296. By Roger Peppe on 2012-07-11

charm: avoid crash when reading charms with simple relation strings.

Fixes bug #1015700

R=niemeyer
CC=
https://codereview.appspot.com/6344105

295. By Aram Hăvărneanu on 2012-07-11

mstate: refactor tests like in state.

Tests are refactored into multiple suites to be compatible with
state. See issue 6348053. After mstate replaces state I plan to reverse
the dependencies between suites. Right now each suite embeds an UtilSuite
and has to call UtilSuite.SetUpTest resulting in error prone duplicate
code. Keeping the multiple suites as containers for data and embedding
all suites into a StateSuite shared by all tests is a better design. We
will keep tests in separate files.

R=niemeyer
CC=
https://codereview.appspot.com/6381045

294. By Aram Hăvărneanu on 2012-07-11

mstate: don't use global sequencing for units.

Inside the mstate package, we shouldn't be using the service name
directly as a sequence name, since it kills the whole namespace. In
fact, the sequence for units is a special case, and should live inside
the service itself, since we want it to be garbage collected with the
service, and want it to reset if the service is removed/re-added.

R=niemeyer
CC=
https://codereview.appspot.com/6357071

293. By Aram Hăvărneanu on 2012-07-10

mstate: removing a node removes associated nodes.

R=niemeyer
CC=
https://codereview.appspot.com/6356060