Merge lp://staging/~rogpeppe/juju-core/393-1.14-fix-live-test into lp://staging/juju-core/1.14
Proposed by
Roger Peppe
Status: | Merged |
---|---|
Approved by: | Roger Peppe |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1742 |
Proposed branch: | lp://staging/~rogpeppe/juju-core/393-1.14-fix-live-test |
Merge into: | lp://staging/juju-core/1.14 |
Diff against target: |
21 lines (+3/-1) 1 file modified
environs/jujutest/livetests.go (+3/-1) |
To merge this branch: | bzr merge lp://staging/~rogpeppe/juju-core/393-1.14-fix-live-test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+185474@code.staging.launchpad.net |
Commit message
environs/jujutest: fix test for Prepare
This is a backport to 1.14 of a fix that is already in trunk.
Description of the change
environs/jujutest: fix test for Prepare
This is a backport to 1.14 of a fix that is already in trunk.
To post a comment you must log in.
Reviewers: mp+185474_ code.launchpad. net,
Message:
Please take a look.
Description:
environs/jujutest: fix test for Prepare
This is a backport to 1.14 of a fix that is already in trunk.
https:/ /code.launchpad .net/~rogpeppe/ juju-core/ 393-1.14- fix-live- test/+merge/ 185474
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/13251047/
Affected files (+5, -1 lines): jujutest/ livetests. go
A [revision details]
M environs/
Index: [revision details] 20130911073858- zypv9bm333hoy99 6
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-
+New revision: <email address hidden>
Index: environs/ jujutest/ livetests. go jujutest/ livetests. go' jujutest/ livetests. go 2013-09-11 06:27:05 +0000 jujutest/ livetests. go 2013-09-13 11:47:04 +0000
=== modified file 'environs/
--- environs/
+++ environs/
@@ -828,7 +828,7 @@
env, err := environs.New(cfg)
c.Assert(err, IsNil)
- dummyenv, err := environs. NewFromAttrs( map[string] interface{ }{ New(map[ string] interface{ }{ private- key": coretesting.CAKey, Prepare( dummyCfg) Destroy( nil)
+ dummyCfg, err := config.
"type": "dummy",
"name": "dummy storage",
"secret": "pizza",
@@ -837,6 +837,8 @@
"ca-
})
c.Assert(err, IsNil)
+ dummyenv, err := environs.
+ c.Assert(err, IsNil)
defer dummyenv.
// BUG: We destroy the environment, then write to its storage.