Merge lp://staging/~rogpeppe/juju-core/276-multiwatcher-constraints into lp://staging/~juju/juju-core/trunk

Proposed by Roger Peppe
Status: Merged
Approved by: William Reade
Approved revision: no longer in the source branch.
Merged at revision: 1146
Proposed branch: lp://staging/~rogpeppe/juju-core/276-multiwatcher-constraints
Merge into: lp://staging/~juju/juju-core/trunk
Diff against target: 298 lines (+138/-20)
6 files modified
state/api/params/params.go (+4/-3)
state/api/params/params_test.go (+8/-6)
state/constraints.go (+10/-6)
state/megawatcher.go (+55/-1)
state/megawatcher_internal_test.go (+54/-3)
state/service.go (+7/-1)
To merge this branch: bzr merge lp://staging/~rogpeppe/juju-core/276-multiwatcher-constraints
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+157875@code.staging.launchpad.net

Description of the change

state/api: add Constraints to AllWatcher

https://codereview.appspot.com/8568044/

To post a comment you must log in.
Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+157875_code.launchpad.net,

Message:
Please take a look.

Description:
state/api: add Constraints to AllWatcher

https://code.launchpad.net/~rogpeppe/juju-core/276-multiwatcher-constraints/+merge/157875

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8568044/

Affected files:
   A [revision details]
   M state/api/params/params.go
   M state/api/params/params_test.go
   M state/constraints.go
   M state/megawatcher.go
   M state/megawatcher_internal_test.go
   M state/service.go

Revision history for this message
Roger Peppe (rogpeppe) wrote :

*** Submitted:

state/api: add Constraints to AllWatcher

R=
CC=
https://codereview.appspot.com/8568044

https://codereview.appspot.com/8568044/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches