Code review comment for lp://staging/~rogpeppe/godeps/004-no-go-get

Revision history for this message
Casey Marshall (cmars) wrote :

https://codereview.appspot.com/230460044/diff/1/godeps.go
File godeps.go (right):

https://codereview.appspot.com/230460044/diff/1/godeps.go#newcode189
godeps.go:189: rootDir := filepath.Join(buildContext.GOPATH, "src",
filepath.FromSlash(root.Root))
What if $GOPATH is a list of paths?

https://codereview.appspot.com/230460044/diff/1/godeps.go#newcode200
godeps.go:200: return err
Might be nice to annotate the cause of this error, to help the user fix
their GOPATH.

https://codereview.appspot.com/230460044/

« Back to merge proposal