Merge lp://staging/~rogpeppe/godeps/003-pkgrepo into lp://staging/godeps

Proposed by Roger Peppe
Status: Merged
Merged at revision: 28
Proposed branch: lp://staging/~rogpeppe/godeps/003-pkgrepo
Merge into: lp://staging/godeps
Diff against target: 820 lines (+800/-0)
4 files modified
pkgrepo/discovery.go (+76/-0)
pkgrepo/http.go (+92/-0)
pkgrepo/other.go (+35/-0)
pkgrepo/vcs.go (+597/-0)
To merge this branch: bzr merge lp://staging/~rogpeppe/godeps/003-pkgrepo
Reviewer Review Type Date Requested Status
godeps-maintainers Pending
Review via email: mp+255866@code.staging.launchpad.net

Description of the change

pkgrepo: new package

We want to be able to fetch a repository without
fetching its dependencies too.
The Go tool can't currently do that, so this
change copies the relevant parts of it
into the pkgrepo directory.

It's not complete yet (the buildV and buildX flags
need some work), but it works.
A later change will change godeps to use it.

https://codereview.appspot.com/223390043/

To post a comment you must log in.
Revision history for this message
Roger Peppe (rogpeppe) wrote :

Reviewers: mp+255866_code.launchpad.net,

Message:
Please take a look.

Description:
pkgrepo: new package

We want to be able to fetch a repository without
fetching its dependencies too.
The Go tool can't currently do that, so this
change copies the relevant parts of it
into the pkgrepo directory.

It's not complete yet (the buildV and buildX flags
need some work), but it works.
A later change will change godeps to use it.

https://code.launchpad.net/~rogpeppe/godeps/003-pkgrepo/+merge/255866

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/223390043/

Affected files (+802, -0 lines):
   A [revision details]
   A pkgrepo/discovery.go
   A pkgrepo/http.go
   A pkgrepo/other.go
   A pkgrepo/vcs.go

Revision history for this message
Martin Hilton (martin-hilton) wrote :

On 2015/04/10 17:30:51, rog wrote:
> Please take a look.

LGTM

https://codereview.appspot.com/223390043/

Revision history for this message
Francesco Banconi (frankban) wrote :
Revision history for this message
Roger Peppe (rogpeppe) wrote :

*** Submitted:

pkgrepo: new package

We want to be able to fetch a repository without
fetching its dependencies too.
The Go tool can't currently do that, so this
change copies the relevant parts of it
into the pkgrepo directory.

It's not complete yet (the buildV and buildX flags
need some work), but it works.
A later change will change godeps to use it.

R=martin.hilton, frankban
CC=
https://codereview.appspot.com/223390043

https://codereview.appspot.com/223390043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches