Merge lp://staging/~rodsmith/hwcert-tools/show-hw into lp://staging/~hardware-certification/hwcert-tools/reporting-tools
Proposed by
Rod Smith
| Status: | Merged |
|---|---|
| Approved by: | Jeff Lane |
| Approved revision: | 157 |
| Merged at revision: | 170 |
| Proposed branch: | lp://staging/~rodsmith/hwcert-tools/show-hw |
| Merge into: | lp://staging/~hardware-certification/hwcert-tools/reporting-tools |
| Diff against target: |
183 lines (+179/-0) 1 file modified
certification_reports/show_hw.py (+179/-0) |
| To merge this branch: | bzr merge lp://staging/~rodsmith/hwcert-tools/show-hw |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeff Lane | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-10-28.
Description of the change
Added new show_hw script, which pulls down dmidecode data from C3. This script is a bit hacky, but is adequate for my immediate needs. Requesting merge in case it might be useful to others in the future, either as-is or as a base for further refinement.
Resubmission: Addressed Jeff's comment.
To post a comment you must log in.
Revision history for this message
| Jeff Lane (bladernr) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Other than one minor nitpick that really is a semantics issue, I'm fine iwth this. If you don't want to change the shebang line, that's fine too, just say so and I'll approve.