Merge lp://staging/~rodsmith/hwcert-tools/multi-iperf3 into lp://staging/~leftyfb/hwcert-tools/cert-precheck

Proposed by Rod Smith
Status: Merged
Approved by: Mike Rushton
Approved revision: 20
Merged at revision: 20
Proposed branch: lp://staging/~rodsmith/hwcert-tools/multi-iperf3
Merge into: lp://staging/~leftyfb/hwcert-tools/cert-precheck
Diff against target: 45 lines (+29/-7)
1 file modified
cert-precheck (+29/-7)
To merge this branch: bzr merge lp://staging/~rodsmith/hwcert-tools/multi-iperf3
Reviewer Review Type Date Requested Status
Mike Rushton Approve
Review via email: mp+283701@code.staging.launchpad.net

Description of the change

Mike,

I've looked over your pre-certification script, and have these changes for you. The issue is that your script didn't parse multiple iperf targets in /etc/xdg/canonical-certification.conf, or check for iperf3 servers. My patch does that. A few notes:

* It mostly-replicates the iperf2 code to test iperf3. I'd rather do a loop, but that started to get hairy in various ways, so I left it with mostly-replicated code instead.
* I use an iperf3 call to check for the presence of the server rather than nc because I discovered that the iperf3 server terminates after several unsuccessful connection attempts by nc, so the test could end up causing problems if nc were used. This has the drawback that the script will pause for a bit if an IP address is invalid, but otherwise it seems to work fine.
* My change is a little verbose in what it reports, but trimming it more might make it less useful.

To post a comment you must log in.
Revision history for this message
Mike Rushton (leftyfb) :
review: Approve
Revision history for this message
Mike Rushton (leftyfb) wrote :

Looks good. Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: