Merge lp://staging/~rodrigo-moya/libubuntuone/progress-downloads-only into lp://staging/libubuntuone

You should probably g_slist_free (keys) when you're done using it, no?

30 + for (keys = g_hash_table_get_keys (current_downloads);
31 + keys != NULL; ) {
32 + g_hash_table_insert (downloads_in_progress, g_strdup (keys->data), g_strdup (keys->data));
33 + keys = g_slist_remove (keys, keys->data);
34 + }

Also, does this for loop work correctly? _get_keys does return a GList and not a GSList, so I suspect that may also cause problems. The documentation also states you shouldn't free the items in the list, as they're owned by the hash table still, and you should only g_list_free() when done using the list returned.

I prefer the keys = _get_keys(); for (l = keys; l != NULL && l->data != NULL; l = l->next) syntax for looping through G[S]Lists though.

Works!

> You should probably g_slist_free (keys) when you're done using it, no?
>
> 30 + for (keys = g_hash_table_get_keys (current_downloads);
> 31 + keys != NULL; ) {
> 32 + g_hash_table_insert (downloads_in_progress, g_strdup (keys->data),
> g_strdup (keys->data));
> 33 + keys = g_slist_remove (keys, keys->data);
> 34 + }
>
> Also, does this for loop work correctly? _get_keys does return a GList and not
> a GSList, so I suspect that may also cause problems. The documentation also
> states you shouldn't free the items in the list, as they're owned by the hash
> table still, and you should only g_list_free() when done using the list
> returned.
>
this is already fixed. g_list_remove returns NULL when there are no more items on the list, so there's nothing to g_list_free