Merge lp://staging/~rockstar/phazr/phazr-overlay into lp://staging/phazr
Proposed by
Paul Hummer
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Paul Hummer | ||||
| Approved revision: | 18 | ||||
| Merged at revision: | 7 | ||||
| Proposed branch: | lp://staging/~rockstar/phazr/phazr-overlay | ||||
| Merge into: | lp://staging/phazr | ||||
| Prerequisite: | lp://staging/~rockstar/phazr/modal-plugin-to-extension | ||||
| Diff against target: |
156 lines (+63/-6) 7 files modified
examples/overlay/index.html (+6/-2) src/css/phazr.css (+4/-0) src/js/modaloverlay/modaloverlay.js (+14/-2) src/js/phazroverlay/phazroverlay.js (+6/-0) tests/index.html (+4/-0) tests/modaloverlay.js (+5/-2) tests/phazroverlay.js (+24/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~rockstar/phazr/phazr-overlay | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Albisetti (community) | Approve | ||
| Deryck Hodge | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch adds more testing to the modaloverlay extension.
It also creates an abstracted PhazrOverlay that provides all the features we want. It's really small, just like Overlay it (Overlay actually has no code, it's a culmination of extensions blended together).
While I was here, I also made ModalOverlay modal by making it draggable by its header. Now you can move it around, etc.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Works as advertised, code looks good!