Merge lp://staging/~rockstar/phazr/modal-plugin-to-extension into lp://staging/phazr
Proposed by
Paul Hummer
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 14 |
| Merged at revision: | 6 |
| Proposed branch: | lp://staging/~rockstar/phazr/modal-plugin-to-extension |
| Merge into: | lp://staging/phazr |
| Diff against target: |
169 lines (+51/-48) 4 files modified
examples/modaloverlay/index.html (+9/-8) src/js/modaloverlay/modaloverlay.js (+29/-29) tests/index.html (+2/-2) tests/modaloverlay.js (+11/-9) |
| To merge this branch: | bzr merge lp://staging/~rockstar/phazr/modal-plugin-to-extension |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Albisetti (community) | Approve | ||
| Deryck Hodge | Pending | ||
|
Review via email:
|
|||
Description of the change
So... it turns out that my ModalPlugin would work better as a widget extension instead of a plugin. I'm not sure I'll port the FormPlugin over, since it seems to make more sense as a plugin (for now).
Ideally, I can move on to making a truly modal dialog (one that can be draggable) very soon.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
21 <h1>Modal Plugin for Overlays</h1>
22 <p>Modal Plugin allows on overlay to operate more like a modal dialog.
23 It has a "close" button at the top right and will also close when hitting
24 "Esc" on the keyboard or clicking outside the overlay.</p>
Missed a few s/Plugin/Overlay here.
Code looks good!