bzr-builder

Merge lp://staging/~rockstar/bzr-builder/fix-underunder-str-underunder into lp://staging/bzr-builder

fix-underunder-str-underunder
Merge into trunk

Proposed by Paul Hummer on 2010-09-15

Status:	Merged
Merged at revision:	106
Proposed branch:	lp://staging/~rockstar/bzr-builder/fix-underunder-str-underunder
Merge into:	lp://staging/bzr-builder
Diff against target:	37 lines (+11/-7) 1 file modified recipe.py (+11/-7)
To merge this branch:	bzr merge lp://staging/~rockstar/bzr-builder/fix-underunder-str-underunder
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
James Westby		2010-09-15	Needs Fixing on 2010-09-15
Review via email: mp+35560@code.staging.launchpad.net

Description of the change

This branch takes the logic of __str__ and puts it in a method that takes a validate parameter. By doing this, it allows us a fallback plan in cases where the recipe may be invalid. For Launchpad at least, this actually means that users that may have corrupt data stored in the database can fix the problem themselves.

Revision history for this message

James Westby (james-w) wrote on 2010-09-15:

Hi,

The manifest creation code uses str(), and I think it should validate.

In addition, I would like to see tests for this new code. Let me know
if you want help with that.

Thanks,

James

review: Needs Fixing

Revision history for this message

Paul Hummer (rockstar) wrote on 2010-09-16:

I could use help with the tests, sure. I'm not sure what you mean by "I think it should validate." It does parse the recipe because it passes validate=True to get_recipe_text.