Twitter WebApp

Merge lp://staging/~robru/unity-webapps-twitter/add-manifest into lp://staging/unity-webapps-twitter

  1. add-manifest
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Superseded
Proposed branch: lp://staging/~robru/unity-webapps-twitter/add-manifest
Merge into: lp://staging/unity-webapps-twitter
Diff against target: 5 lines (+1/-0)
1 file modified
manifest.json (+1/-0)
To merge this branch: bzr merge lp://staging/~robru/unity-webapps-twitter/add-manifest
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Víctor R. Ruiz Pending
Review via email: mp+163032@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-05-07.

This proposal has been superseded by a proposal from 2013-05-09.

Commit message

Add manifest.json for Twitter.

Description of the change

Took a stab at making the missing manifest.json for Twitter, not sure how correct it is though.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote : Posted in a previous version of this proposal

Jenkins is still confused about rules.mk because it doesn't have the right PPA enabled in order to run it's ci tests. I guess victor will need to fix that.

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote : Posted in a previous version of this proposal

Check out the manifest.js script in webapps-applications it basically does that for you ... (although it might need to be tweaked to account for the splitted environment), it is not currently being used nor distributed,

Revision history for this message
Alexandre Abreu (abreu-alexandre) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote : Posted in a previous version of this proposal

manifest.json not being used? erk, well maybe we should delete them then? I guess all the same info is in debian/control and within the script itself, right?

Because you're wrong about them not being distributed, all 41 debian/install files try to install manifest.json into the system, and that is what caused the build failure that this branch aims to fix...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-autolanding/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-autolanding/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-autolanding/1/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote : Posted in a previous version of this proposal

Please, resubmit to rebuild.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:5
http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-twitter-raring-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-twitter-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote : Posted in a previous version of this proposal

(Just for the sake of completeness), I said "manifest.js" not being used not "manifest.json" ... manifest.js is a simple script that is used to generate a manifest.json out of a user script file,

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: