GoogleNews WebApp

Merge lp://staging/~robru/unity-webapps-googlenews/add-manifest into lp://staging/unity-webapps-googlenews

  1. add-manifest
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 22
Merged at revision: 21
Proposed branch: lp://staging/~robru/unity-webapps-googlenews/add-manifest
Merge into: lp://staging/unity-webapps-googlenews
Diff against target: 27 lines (+3/-2)
2 files modified
GoogleNews.user.js (+2/-2)
manifest.json (+1/-0)
To merge this branch: bzr merge lp://staging/~robru/unity-webapps-googlenews/add-manifest
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
WebApps Pending
Review via email: mp+169557@code.staging.launchpad.net

Commit message

Add missing manifest.json

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:20
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-googlenews-ci/1/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~robru/unity-webapps-googlenews/add-manifest updated
21. By Robert Bruce Park

Change const to var.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:21
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-googlenews-ci/2/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~robru/unity-webapps-googlenews/add-manifest updated
22. By Robert Bruce Park

Appease jslint.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:22
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlenews-saucy-armhf-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-googlenews-ci/3/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: