Merge lp://staging/~robru/friends/twitter-retweet into lp://staging/friends
Proposed by
Robert Bruce Park
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ken VanDine | ||||
| Approved revision: | 190 | ||||
| Merged at revision: | 189 | ||||
| Proposed branch: | lp://staging/~robru/friends/twitter-retweet | ||||
| Merge into: | lp://staging/friends | ||||
| Diff against target: |
159 lines (+67/-9) 5 files modified
friends/protocols/twitter.py (+16/-1) friends/tests/data/twitter-retweet.dat (+1/-0) friends/tests/mocks.py (+1/-0) friends/tests/test_identica.py (+3/-2) friends/tests/test_twitter.py (+46/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~robru/friends/twitter-retweet | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ken VanDine | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Fix Twitter.retweet (LP: #1168427)
Description of the change
Fixes Twitter.retweet method, which wasn't supplying sender name / avatar correctly due to the information being missing from twitter.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:189
http://
Executed test runs:
FAILURE: http://
Click here to trigger a rebuild:
http://