Friends

Merge lp://staging/~robru/friends/notify-no-html into lp://staging/friends

  1. notify-no-html
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Approved by: Ken VanDine
Approved revision: 183
Merged at revision: 187
Proposed branch: lp://staging/~robru/friends/notify-no-html
Merge into: lp://staging/friends
Diff against target: 48 lines (+17/-3)
2 files modified
friends/tests/test_notify.py (+13/-0)
friends/utils/base.py (+4/-3)
To merge this branch: bzr merge lp://staging/~robru/friends/notify-no-html
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+157732@code.staging.launchpad.net

Commit message

Don't add HTML links to the notification, only to the DeeModel

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:183
http://jenkins.qa.ubuntu.com/job/friends-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/friends-raring-amd64-ci/26

Click here to trigger a rebuild:
http://s-jenkins:8080/job/friends-ci/26/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Fixed the bug and works great, looks like you unintentionally removed some leading white space from a comment on line 350 of base.py.

review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

Weird about the leading space, you're right that that's a mistake... oh well, harmless.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches