Merge lp://staging/~robru/friends/linkedin-protocol into lp://staging/friends

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 205
Merged at revision: 223
Proposed branch: lp://staging/~robru/friends/linkedin-protocol
Merge into: lp://staging/friends
Diff against target: 884 lines (+599/-56)
10 files modified
debian/control (+16/-7)
debian/friends-linkedin.install (+1/-0)
friends/protocols/facebook.py (+4/-10)
friends/protocols/linkedin.py (+137/-0)
friends/protocols/twitter.py (+4/-12)
friends/tests/data/linkedin_contacts.json (+53/-0)
friends/tests/data/linkedin_receive.json (+177/-0)
friends/tests/test_facebook.py (+6/-12)
friends/tests/test_linkedin.py (+182/-0)
friends/utils/base.py (+19/-15)
To merge this branch: bzr merge lp://staging/~robru/friends/linkedin-protocol
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Robert Bruce Park Approve
Review via email: mp+175416@code.staging.launchpad.net

Commit message

Add LinkedIn support.

Description of the change

So close to landing this! Just need to write a test or two for the contacts implementation.

To post a comment you must log in.
204. By Robert Bruce Park

Safer default value for result.get().

205. By Robert Bruce Park

Scrubbed demo data and test coverage for LinkedIn contacts.

Revision history for this message
Robert Bruce Park (robru) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches