frame

Merge lp://staging/~robru/frame/inline-packaging into lp://staging/frame

  1. inline-packaging
  2. Merge into trunk
Proposed by Robert Bruce Park
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 104
Merged at revision: 104
Proposed branch: lp://staging/~robru/frame/inline-packaging
Merge into: lp://staging/frame
Diff against target: 300 lines (+249/-0)
10 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+38/-0)
debian/compat (+1/-0)
debian/control (+60/-0)
debian/copyright (+39/-0)
debian/frame-tools.install (+2/-0)
debian/libframe-dev.install (+3/-0)
debian/libframe6.install (+1/-0)
debian/libframe6.symbols (+95/-0)
debian/rules (+8/-0)
To merge this branch: bzr merge lp://staging/~robru/frame/inline-packaging
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+135788@code.staging.launchpad.net

Commit message

Add inline packaging

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Test pass, everything builds! Good work :)

Can you just (as per my other MR comment), remove:
297 +ifneq ($(wildcard autogen.sh),)
298 + DEB_BUILD_OPTIONS += nostrip
299 +endif

Then, getting jenkins merging this would be awesome. I pinged mmrazik to set that up

(needs fixing for now just to change the debian/rules for nostrip)

review: Needs Fixing
lp://staging/~robru/frame/inline-packaging updated
104. By Robert Bruce Park

Fix debian/rules as per didrocks.

Revision history for this message
Robert Bruce Park (robru) wrote :

Fixed, please approve ;-)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I approve then :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches