Merge lp://staging/~robru/evemu/inline-packaging into lp://staging/evemu

Proposed by Robert Bruce Park
Status: Merged
Approved by: Francis Ginther
Approved revision: 64
Merged at revision: 63
Proposed branch: lp://staging/~robru/evemu/inline-packaging
Merge into: lp://staging/evemu
Diff against target: 303 lines (+247/-0)
11 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+88/-0)
debian/compat (+1/-0)
debian/control (+75/-0)
debian/copyright (+38/-0)
debian/evemu-tools.install (+2/-0)
debian/libevemu-dev.install (+3/-0)
debian/libevemu1.install (+1/-0)
debian/libevemu1.symbols (+28/-0)
debian/python-evemu.install (+1/-0)
debian/rules (+8/-0)
To merge this branch: bzr merge lp://staging/~robru/evemu/inline-packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Didier Roche-Tolomelli Approve
Review via email: mp+135787@code.staging.launchpad.net

Commit message

Add inline packaging

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Like for the others of the oif stack! Good works (and no jenkins, need to happen ;))

You also need to remove:
299 +# Act differently if this is a native (daily) build or not.
300 +ifneq ($(wildcard autogen.sh),)
301 + DEB_BUILD_OPTIONS += nostrip
302 +endif

Hence the needs fixing for now, all the rest is good, builds fine, and so on… :)

review: Needs Fixing
Revision history for this message
Robert Bruce Park (robru) wrote :

Fixed, please approve ;-)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

How can I say no? ;)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified.

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Re-approving now that the build configuration issues have been worked out.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches