wicd

Merge lp://staging/~robin-reportlab/wicd/wifi-nevershow into lp://staging/wicd/1.6

wifi-nevershow
Merge into experimental

Proposed by Robin Becker on 2011-09-18

Status:	Merged
Approved by:	David Paleino on 2011-10-04
Approved revision:	591
Merged at revision:	597
Proposed branch:	lp://staging/~robin-reportlab/wicd/wifi-nevershow
Merge into:	lp://staging/wicd/1.6
Diff against target:	298 lines (+106/-10) 7 files modified data/wicd.ui (+40/-5) gtk/gui.py (+6/-1) gtk/netentry.py (+26/-2) gtk/prefs.py (+4/-0) gtk/wicd-client.py (+3/-1) wicd/translations.py (+3/-0) wicd/wicd-daemon.py (+24/-1)
To merge this branch:	bzr merge lp://staging/~robin-reportlab/wicd/wifi-nevershow
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
David Paleino		2011-09-18	Approve on 2011-10-04
Review via email: mp+75900@code.staging.launchpad.net

Description of the change

This patch adds support for an extra checkbox in the wireless entries

'Never connect to this network'

which if checked removes the entry from future listing.

In addition an extra checkbox preference is added to general preferences

'Show never connect networks'/'Hide never connect networks'

which controls whether the neverconnect networks should be listed or not.

I originally coded this against 563, but this branch is a patched 590.

Revision history for this message

David Paleino (dpaleino) wrote on 2011-09-18:

Hello Robin,
your patch seems generally good. However, it introduces some new translatable
strings, and I'm still quite unfamiliar with the current translation framework.
I've proposed the "old" admins to switch to LP's Rosetta, but until then, I can
merge the code without the changes to translations.py (yes, I did that too with rfkill support, but I thought at it later :/)

I'll surely include this in 1.7.1 though (this means that 1.7.1 needs to wait for other team members to explain me how to work with translations :)).

Thanks for your contribution,
David

Revision history for this message

Robin Becker (robin-reportlab) wrote on 2011-09-18:

........
>
> I'll surely include this in 1.7.1 though (this means that 1.7.1 needs to wait
> for other team members to explain me how to work with translations :)).
>
.....
using a network controller's setup.py to download seems quite optimistic; I was wondering why the translations dir was empty :)