snappy-hwe-snaps

Merge ~robertliu/snappy-hwe-snaps/+git/modme-manager:add-test-options-20 into ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:snap-20

  1. Git
  2. lp:~robertliu/snappy-hwe-snaps/+git/modme-manager
  3. add-test-options-20
  4. Merge into snap-20
Proposed by Robert Liu
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 2f588845201c383f718a10a945aeda96f60cbda1
Merged at revision: 1719f336199722696004210e39187cfd29fb6500
Proposed branch: ~robertliu/snappy-hwe-snaps/+git/modme-manager:add-test-options-20
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:snap-20
Diff against target: 44 lines (+26/-1)
2 files modified
bin/modemmanager (+14/-1)
hooks/configure (+12/-0)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+435808@code.staging.launchpad.net

Description of the change

Backport from this MP: https://code.launchpad.net/~robertliu/snappy-hwe-snaps/+git/modme-manager/+merge/434059

Add two options to enable `--test-no-suspend-resume` and `--test-quick-suspend-resume` dynamically.

* sudo snap set modem-manager test.no-suspend-resume to enable --test-no-suspend-resume
* sudo snap set modem-manager test.quick-suspend-reusme to enable --test-quick-suspend-resume

I'll submit another MP once the restarting service mechanism has been done.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 2f588845201c383f718a10a945aeda96f60cbda1

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1604/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:2f588845201c383f718a10a945aeda96f60cbda1
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/800/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/823
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/823/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/823
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/823
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1604
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1346
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1414/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/800/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 2f588845201c383f718a10a945aeda96f60cbda1

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1605/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:2f588845201c383f718a10a945aeda96f60cbda1
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/801/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/824
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/824
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/824
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/824
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1605
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1347
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1415/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/801/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Liu (robertliu) wrote :

Hi Aflonso,

Could you please review this MP?
This MP doesn't auto restart modem-manager after setting options. So far, I haven't yet digged into the auto-restart MP[1]. But I'm wondering if we can have this MP got merged first.

[1] https://code.launchpad.net/~robertliu/snappy-hwe-snaps/+git/modme-manager/+merge/434168

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM, thank you

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Could you please also propose for snap-22 branch?

Revision history for this message
Robert Liu (robertliu) wrote :

The MP[1] for snap-22 branch was merged already. The one I mentioned in my previous comment is to restart MM automatically when the the any of suspend options is changed.

[1] https://code.launchpad.net/~robertliu/snappy-hwe-snaps/+git/modme-manager/+merge/434059

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Oh, I had fully forgotten about that one, it was already merged indeed :)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: