platform-api

Merge lp://staging/~robertcarr/platform-api/update-mir-deprecation into lp://staging/platform-api

  1. update-mir-deprecation
  2. Merge into trunk
Proposed by Robert Carr
Status: Needs review
Proposed branch: lp://staging/~robertcarr/platform-api/update-mir-deprecation
Merge into: lp://staging/platform-api
Diff against target: 29 lines (+9/-3)
1 file modified
src/ubuntu/mirclient/window_mirclient.cpp (+9/-3)
To merge this branch: bzr merge lp://staging/~robertcarr/platform-api/update-mir-deprecation
Reviewer Review Type Date Requested Status
Alberto Aguirre (community) Needs Fixing
Gerry Boland (community) Needs Information
PS Jenkins bot continuous-integration Approve
Review via email: mp+213142@code.staging.launchpad.net

Commit message

Update to avoid use of a deprecated mir function (mir_connection_get_display_info). (LP: #1369425)

Description of the change

Just noticed this while building stuff. Update to avoid use of a deprecated mir function.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:205
http://jenkins.qa.ubuntu.com/job/platform-api-ci/242/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-amd64-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-armhf-ci/76
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-armhf-ci/76/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-i386-ci/76

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/242/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

This still relevant?

review: Needs Information
Reply
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Yeah still relevant, deprecated api is still used except now in one more place:

src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp
173: mir_connection_get_display_info(instance->connection(), display);

review: Needs Fixing
Reply

Unmerged revisions

205. By Robert Carr

Update deprecated mir API usage

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches