Mir

Merge lp://staging/~robertcarr/mir/android-test-powerd-cli into lp://staging/mir

  1. android-test-powerd-cli
  2. Merge into development-branch
Proposed by Robert Carr
Status: Rejected
Rejected by: Robert Carr
Proposed branch: lp://staging/~robertcarr/mir/android-test-powerd-cli
Merge into: lp://staging/mir
Diff against target: 36 lines (+6/-2)
2 files modified
debian/control (+1/-0)
debian/rules (+5/-2)
To merge this branch: bzr merge lp://staging/~robertcarr/mir/android-test-powerd-cli
Reviewer Review Type Date Requested Status
Daniel van Vugt Disapprove
Alan Griffiths Abstain
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+193167@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-10-28.

Commit message

Use powerd-cli to ensure the screen is powered during packaging test runs on armhf.

Description of the change

A pragmatic fix for: https://bugs.launchpad.net/mir/+bug/1239955 in light of https://code.launchpad.net/~chris.gagnon/mir/enabled-arm-tests/+merge/191991

As documented in the bug, in some sense this is not a mir bug, merely mir fails when the system has been put in to earlysuspend mode by some other component. See the bug for more detailed documentation.

This isn't a problem in the Unity8 scenario, as Unity8 speaks with powerd (it seems, unity-system-compositor will need to do the same).

I think as such, it's reasonable to simply ensure the system is active during our packaging test runs.

It's still potentially confusing for developers: adb shell in to phablet, but everything is off (because you stopped unity8 while the screen was blanked) and mir doesn't work. Maybe this is best solved at a different level.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1164
http://jenkins.qa.ubuntu.com/job/mir-ci/1606/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/19
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-trusty-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-trusty-armhf-ci/4/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/mir-ci/1606/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:1165
http://jenkins.qa.ubuntu.com/job/mir-ci/1607/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/20
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-trusty-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-trusty-armhf-ci/5/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/mir-ci/1607/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:1166
http://jenkins.qa.ubuntu.com/job/mir-ci/1608/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-trusty-amd64-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/mir-trusty-amd64-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-trusty-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/mir-trusty-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/mir-ci/1608/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

Please target for development-branch.

review: Needs Resubmitting
Revision history for this message
Kevin DuBois (kdub) wrote : Posted in a previous version of this proposal

We're adding a dependency in order to make sure that another program doesn't come and mess up the environment we need for adding a test? seems like we should set up pbuilder to do this, or negotiate something in the system architecture to talk to powerd directly.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1166
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/289/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/18/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/18/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/mir-team-mir-development-branch-ci/289/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, so it's not really a fix for bug 1239955 as much as a workaround.

I share Kevin's concern and wonder if this workaround applies to any relevant case where we really need it. I mean, don't our armhf builds run on headless or at least non-Android systems anyway? And if it's for developers then it doesn't help them either because they will run the tests directly (not debian/rules).

P.S. The final chunk looks like it's doing nothing effectively.

review: Needs Information
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Maybe this is best solved at a different level.

Amen

review: Abstain
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Apparently our armhf builds are on Calexda nodes [1], which I assume are headless or at least don't suffer from (Android) bug 1239955. That means this proposal won't help CI. And it also won't help developers.

[1] https://code.launchpad.net/~chris.gagnon/mir/development-branch-disable-trace-children-android/+merge/192391/comments/445717

review: Disapprove
Revision history for this message
Robert Carr (robertcarr) wrote :

It's a shame that we still aren't running our android graphics tests.

Unmerged revisions

1166. By Robert Carr

Do not enable android tests yet

1165. By Robert Carr

Fix spacing

1164. By Robert Carr

Only depend on powerd-cli on armhf

1163. By Robert Carr

Build android gtest discovery

1162. By Robert Carr

Build tests on android

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches