Merge lp://staging/~robert-ancell/update-manager/ua-updates-api into lp://staging/update-manager

Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 2957
Merged at revision: 2959
Proposed branch: lp://staging/~robert-ancell/update-manager/ua-updates-api
Merge into: lp://staging/update-manager
Diff against target: 46 lines (+5/-19)
1 file modified
UpdateManager/UpdateManager.py (+5/-19)
To merge this branch: bzr merge lp://staging/~robert-ancell/update-manager/ua-updates-api
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Grant Orndorff Pending
Review via email: mp+436096@code.staging.launchpad.net

Description of the change

Use uaclient library instead of calling ua tool directly. This simplifies parsing errors. The API is blocking however, so we hold up the UI.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, makes sense, that's what the pro client team suggested using, it would also have avoided the recently issue when the parsing wasn't working anymore due to them changing one of the key names

review: Approve
Revision history for this message
Kiwinote (kiwinote) wrote :

Hi there - just wanted to let you know that this change might have caused a regression in update-manager as described at https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2008280 - if you're able to take a quick look that would be much appreciated - thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: