GoogleCalendar WebApp

Merge lp://staging/~robert-ancell/unity-webapps-googlecalendar/app-name into lp://staging/unity-webapps-googlecalendar

  1. app-name
  2. Merge into trunk
Proposed by Robert Ancell
Status: Needs review
Proposed branch: lp://staging/~robert-ancell/unity-webapps-googlecalendar/app-name
Merge into: lp://staging/unity-webapps-googlecalendar
Diff against target: 38 lines (+6/-6)
3 files modified
GoogleCalendargooglecom.desktop (+2/-2)
debian/control (+3/-3)
manifest.json (+1/-1)
To merge this branch: bzr merge lp://staging/~robert-ancell/unity-webapps-googlecalendar/app-name
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alexandre Abreu (community) Needs Fixing
Justin McPherson Approve
Review via email: mp+218243@code.staging.launchpad.net

Description of the change

Correct name by adding in space. I'm not sure what XB-Ubuntu-Webapps-Name in debian/control is used for an if that too is a human readable name (i.e. "Google Calendar") or an ID (i.e. "GoogleCalendar").

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:70
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-trusty-armhf-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-googlecalendar-ci/8/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Justin McPherson (justinmcp) :
review: Approve
Reply
Revision history for this message
David Barth (dbarth) wrote :

Just verifying with Alex that that name parameter has no implication with technical paths to find the webapp supporting JS code.

Reply
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

You need to modify:

- the manifest.json file to update the name as well,
- the Exec line for the desktop file contains a base64 encoded string corresponding to the name,

unity-webapps-runner -n 'R29vZ2xlQ2FsZW5kYXI='

which needs to be updated too,

- you can also change the X-Ubuntu- name,

review: Needs Fixing
Reply
lp://staging/~robert-ancell/unity-webapps-googlecalendar/app-name updated
71. By Robert Ancell

Update manifest name

72. By Robert Ancell

Update base64 encoded name in Exec line

73. By Robert Ancell

Update XB-Ubuntu-Webapps-Name in debian/control

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:73
http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-utopic-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-googlecalendar-utopic-armhf-ci/1

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-webapps-googlecalendar-ci/9/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

73. By Robert Ancell

Update XB-Ubuntu-Webapps-Name in debian/control

72. By Robert Ancell

Update base64 encoded name in Exec line

71. By Robert Ancell

Update manifest name

70. By Robert Ancell

Correct name from GoogleCalendar to Google Calendar

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: