Unity Control Center

Merge lp://staging/~robert-ancell/unity-control-center/missing-symbols into lp://staging/unity-control-center

  1. missing-symbols
  2. Merge into trunk
Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12782
Merged at revision: 12783
Proposed branch: lp://staging/~robert-ancell/unity-control-center/missing-symbols
Merge into: lp://staging/unity-control-center
Diff against target: 39 lines (+7/-0)
2 files modified
debian/libunity-control-center1.symbols (+6/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp://staging/~robert-ancell/unity-control-center/missing-symbols
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+224546@code.staging.launchpad.net

Commit message

Add symbols that were added in revision 12731

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:12782
http://jenkins.qa.ubuntu.com/job/unity-control-center-ci/100/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-control-center-utopic-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-control-center-ci/100/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, should we also change the rules to use -c4/stop on missing symbols?

review: Approve
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Yes we should, I just never worked out how to do that.

lp://staging/~robert-ancell/unity-control-center/missing-symbols updated
12783. By Robert Ancell

Add the magic to make the build stop when symbols are added

Revision history for this message
Sebastien Bacher (seb128) wrote :

> Yes we should, I just never worked out how to do that.

seems like you just did, thanks ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches