Merge lp://staging/~robert-ancell/onboard/bug-982699 into lp://staging/onboard

Proposed by Robert Ancell
Status: Merged
Merge reported by: marmuta
Merged at revision: not available
Proposed branch: lp://staging/~robert-ancell/onboard/bug-982699
Merge into: lp://staging/onboard
Diff against target: 393 lines (+138/-138)
3 files modified
Onboard/Config.py (+17/-17)
data/com.ubuntu.onboard.gschema.xml (+119/-119)
data/onboard.convert (+2/-2)
To merge this branch: bzr merge lp://staging/~robert-ancell/onboard/bug-982699
Reviewer Review Type Date Requested Status
marmuta Approve
Review via email: mp+102047@code.staging.launchpad.net

Description of the change

See bug 982699. I don't know if there's a migration issue for 0.96.0 and 0.97.0 users.

To post a comment you must log in.
Revision history for this message
marmuta (marmuta) wrote :

Thank you. Yes we would have to migrate the old settings. Snippets in particular, but other stuff, like scanner settings, would be annoying to lose too. There are quit a lot of keys overall, it's probably best to just recursively copy them all.

AFAIK there is no official plan in place for GIO to handle this, but for the majority of installations we can probably pull the old data from dconf. At least this is how I did it before on a smaller scale, see migrate_dconf_value calls in Config.py. migrate_dconf_value doesn't handle a lot of data types yet though.

If you'd like to do this, that would be great, but let's wait until we know what exactly to do, if and where to move to.

Revision history for this message
marmuta (marmuta) wrote :

This is merged now. I've changed the paths to /org/onboard and added migration for all keys. Thanks again, Robert.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches