Bluetooth Menu

Merge lp://staging/~robert-ancell/indicator-bluetooth/handle-null-properties into lp://staging/indicator-bluetooth/15.10

  1. handle-null-properties
  2. Merge into trunk.15.10
Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 92
Merged at revision: 92
Proposed branch: lp://staging/~robert-ancell/indicator-bluetooth/handle-null-properties
Merge into: lp://staging/indicator-bluetooth/15.10
Diff against target: 28 lines (+7/-4)
1 file modified
src/bluez.vala (+7/-4)
To merge this branch: bzr merge lp://staging/~robert-ancell/indicator-bluetooth/handle-null-properties
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+272547@code.staging.launchpad.net

Commit message

Check for NULL when getting cached properties Address and UUIDs.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:92
http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-ci/40/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-wily-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-wily-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-wily-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-bluetooth-ci/40/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Good to not segfault, do you have any idea why we end up with having null values there though?

review: Approve
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I couldn't reproduce any case here where this occurred, my theories are:
- The object is created without these properties and they are updated later (driver dependant?).
- The properties aren't in the proxys cache for some reason (code inspection didn't show any issue I could see on how we set up the proxy).
- The driver / device is faulty and doesn't have these properties.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches