Bluetooth Menu

Merge lp://staging/~robert-ancell/indicator-bluetooth/bluez5 into lp://staging/indicator-bluetooth/15.04

bluez5
Merge into trunk.15.04

Proposed by Robert Ancell on 2014-12-11

Status:

Merged

Approved by:

Sebastien Bacher on 2015-08-12

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~robert-ancell/indicator-bluetooth/bluez5

Merge into:

lp://staging/indicator-bluetooth/15.04

Diff against target:

952 lines (+192/-561)

6 files modified

debian/control (+1/-1)
po/POTFILES.in (+0/-1)
src/Makefile.am (+0/-1)
src/bluez.vala (+191/-253)
src/desktop.vala (+0/-12)
src/org-bluez.vala (+0/-293)

To merge this branch:

bzr merge lp://staging/~robert-ancell/indicator-bluetooth/bluez5

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-08-07
Mathieu Trudel-Lapierre			Approve on 2014-12-16
Didier Roche-Tolomelli		2014-12-11	Approve on 2014-12-16
Review via email: mp+244375@code.staging.launchpad.net

Commit message

Support Bluez 5

When enabling/disabling and setting discoverability we now do this for all
adapters.

This requires us to remove the "Set Up New Device" item since gnome-bluetooth no
longer has a bluetooth wizard stand alone application. Instead we rely on the
unity-control-center panel for device setup.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-11:

PASSED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-vivid-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-vivid-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/indicator-bluetooth-vivid-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-bluetooth-ci/38/rebuild

review: Approve (continuous-integration)

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2014-12-16:

Code looks good to me. I would prefer another review though (like from Mathieu) as my bluetooth is quite flaky and it only worked once (but it was already the case with bluez4).

Maybe you can as well package it and push to the ppa as ~ppa1 so that we can get broader testing?
Thanks!

review: Approve

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2014-12-16:

Looks good to me; but I agree it would be best to package it and make it available in the transitions PPA for further testing.

review: Approve

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2014-12-16:

This is already in the transitions PPA as indicator-bluetooth 0.0.6+14.10.20141006-0ubuntu1+bluezfive

Revision history for this message

Charles Kerr (charlesk) wrote on 2015-03-17:

The code changes look reasonable and the transitions build of indicator-bluetooth works for me when I test it on a fresh installation of the March 6 Vivid iso. In that setup, both the on/off and visible/invisible toggles work as advertised.

Some problems:

* On desktop, "Set Up New Device..." is a feature specified in https://wiki.ubuntu.com/Bluetooth#Indicator_and_menu but is removed here. Can it be salvaged?

* After installing [bluez, indicator-bluetooth, libbluetooth3] on mako running vivid r136. The indicator's bluetooth on/off toggle had no effect. (This might be user error; I don't know if this PPA is supposed to work on the phone...)

* The transitions repository doesn't have unity-control-center in it, so I don't know how far we are for landing this in Vivid?

* The visible/invisible toggle in gnome-control-center didn't show the same state as the indicator. The indicator seemed to hold the correct state.

Revision history for this message

Amr Ibrahim (amribrahim1987) wrote on 2015-07-10:

Any news for packaging this for wily? I think bluez 5 needs broad testing in 15.10 before 16.04 LTS.

lp://staging/~robert-ancell/indicator-bluetooth/bluez5 updated on 2015-08-07