Merge lp://staging/~roadmr/ubuntu/oneiric/checkbox/0.12.8.1 into lp://staging/ubuntu/oneiric/checkbox

Proposed by Daniel Manrique
Status: Needs review
Proposed branch: lp://staging/~roadmr/ubuntu/oneiric/checkbox/0.12.8.1
Merge into: lp://staging/ubuntu/oneiric/checkbox
Diff against target: 279 lines (+82/-54)
10 files modified
checkbox/contrib/persist.py (+5/-4)
checkbox/lib/safe.py (+5/-0)
checkbox/message.py (+4/-3)
checkbox_gtk/gtk_interface.py (+2/-4)
debian/changelog (+20/-0)
gtk/checkbox-gtk.ui (+37/-37)
jobs/input.txt.in (+1/-1)
plugins/persist_info.py (+2/-1)
scripts/connect_wireless (+1/-1)
scripts/usb_test (+5/-3)
To merge this branch: bzr merge lp://staging/~roadmr/ubuntu/oneiric/checkbox/0.12.8.1
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Approve
Review via email: mp+84660@code.staging.launchpad.net

Description of the change

This merge contains some bug fixes we'd like to have on an SRU for Checkbox on Ubuntu 11.10. SRU criteria are presented in each bug's description.

Thanks!

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks for your work. For future reference, please make sure the upload target is set to $dist-proposed for stable release updates, where $dist is oneiric, precise, etc. I'd also ask that you not tag your branches. It is usually up to the uploader to tag a branch, since they may need to make further changes before the upload, and it keeps the work of each upload a little more tidy if the final commit of that upload is tagged. In this case its not a problem, but its something thats worth thinking about in the future.

Thanks again.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi Luke,

Thanks so much for your advice, I'll be sure to follow it in the future. It's only the second SRU I request so I'm still a bit wobbly but I'll improve. Also thanks for reviewing our changes!

Unmerged revisions

36. By Daniel Manrique

 * Ensure that connect_wireless chooses a wireless connection from the list
   of available connections (LP: #877752)
 * Have the bluetooth/detect tests require a device with the category
   BLUETOOTH to run, thus preventing the test from failing on systems with
   no Bluetooth device (LP: #862322)
 * Guard against trying to write files to logical partitions on USB sticks
   (which will obviously fail) in usb_test (LP: #887049)
 * Allow input/mouse test to run if a TOUCH device is present
   (LP: #886129)
 * Flush file descriptors and sync disk before running a test (LP: #814801)
* Move progress indicator to main checkbox dialog instead of a
  transient window (LP: #868995)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches