Merge lp://staging/~roadmr/isitdeployable/existingdeployments into lp://staging/isitdeployable

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 314
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp://staging/~roadmr/isitdeployable/existingdeployments
Merge into: lp://staging/isitdeployable
Diff against target: 696 lines (+404/-26)
16 files modified
dev_config/supervisor.conf (+2/-2)
requirements.txt (+2/-2)
revtracker/admin.py (+8/-0)
revtracker/data.py (+1/-0)
revtracker/migrations/0002_existingdeployment.py (+28/-0)
revtracker/models.py (+37/-0)
revtracker/static/scss/deploy_tracker.scss (+4/-0)
revtracker/tasks.py (+46/-0)
revtracker/templates/revtracker/index.html (+32/-17)
revtracker/templates/revtracker/project_info.html (+16/-0)
revtracker/tests/factory.py (+17/-0)
revtracker/tests/test_models.py (+30/-0)
revtracker/tests/test_tasks.py (+115/-0)
revtracker/tests/test_views.py (+4/-4)
revtracker/tests/test_views_logged_in.py (+52/-0)
revtracker/views.py (+10/-1)
To merge this branch: bzr merge lp://staging/~roadmr/isitdeployable/existingdeployments
Reviewer Review Type Date Requested Status
Facundo Batista (community) Approve
Maximiliano Bertacchini Approve
Review via email: mp+356594@code.staging.launchpad.net

Commit message

Add querying and displaying of which versions of code are deployed in each service/environment.

Each project can have zero or more "Existing Deployments". Periodically, the service will poke a configured URL for each of these deployments, extract the value from a specific header, and store that for display in both the index page and each project's page.

Since most of our projects expose their current version in a X-VCS-Version or similar, this information can be collected for them, and the index page can then provide at a glance an overview of which versions each project is at.

Description of the change

Add querying and displaying of which versions of code are deployed in each service/environment.

Each project can have zero or more "Existing Deployments". Periodically, the service will poke a configured URL for each of these deployments, extract the value from a specific header, and store that for display in both the index page and each project's page.

Since most of our projects expose their current version in a X-VCS-Version or similar, this information can be collected for them, and the index page can then provide at a glance an overview of which versions each project is at.

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

Looks good to me, but have a few comments/questions inline. Thanks!

Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks! Replied below and fixes coming up.

313. By Daniel Manrique

Space... the final frontier

314. By Daniel Manrique

PEP8 fixes

Revision history for this message
Maximiliano Bertacchini (maxiberta) :
review: Approve
Revision history for this message
Facundo Batista (facundo) wrote :

Looks fine! Added a couple of small questions, but approving it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches