Merge lp://staging/~roadmr/isitdeployable/deploymentrequest-admin-fixes into lp://staging/isitdeployable

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 214
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp://staging/~roadmr/isitdeployable/deploymentrequest-admin-fixes
Merge into: lp://staging/isitdeployable
Diff against target: 59 lines (+17/-3)
3 files modified
revtracker/admin.py (+2/-2)
revtracker/models.py (+14/-0)
revtracker/templates/base.html (+1/-1)
To merge this branch: bzr merge lp://staging/~roadmr/isitdeployable/deploymentrequest-admin-fixes
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+310684@code.staging.launchpad.net

Commit message

Optimizations for DeploymentRequest admin:

- Details for a DeploymentRequest timeout because the related fields for revisions do one query per candidate revision (thousaaaaaaaaaaaaaands of queries). A custom manager which does select_related() should help with this.

- Show time/date in the DeploymentRequest list, and allow filtering by date and by project name (otherwise there are hundreds of DeploymentRequests which are hard to navigate).

Description of the change

Optimizations for DeploymentRequest admin:

- Details for a DeploymentRequest timeout because the related fields for revisions do one query per candidate revision (thousaaaaaaaaaaaaaands of queries). A custom manager which does select_related() should help with this.

- Show time/date in the DeploymentRequest list, and allow filtering by date and by project name (otherwise there are hundreds of DeploymentRequests which are hard to navigate).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches