Merge lp://staging/~roadmr/isitdeployable/active-flag into lp://staging/isitdeployable

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 300
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp://staging/~roadmr/isitdeployable/active-flag
Merge into: lp://staging/isitdeployable
Diff against target: 179 lines (+100/-3)
6 files modified
revtracker/migrations/0003_auto_20190906_2215.py (+30/-0)
revtracker/models.py (+7/-1)
revtracker/tasks.py (+6/-0)
revtracker/tests/factory.py (+3/-2)
revtracker/tests/test_models.py (+11/-0)
revtracker/tests/test_tasks.py (+43/-0)
To merge this branch: bzr merge lp://staging/~roadmr/isitdeployable/active-flag
Reviewer Review Type Date Requested Status
Jonathan Hartley (community) Approve
Review via email: mp+372441@code.staging.launchpad.net

Commit message

Add an "Active" flag to Projects. An Inactive project won't be queried anymore for either new revisions or updates to existing deployments, essentially archiving it.

Description of the change

Add an "Active" flag to Projects. An Inactive project won't be queried anymore for either new revisions or updates to existing deployments, essentially archiving it.

The motivation is archiving old bzr-based projects as we migrate them to git, since deployable is too crumbly and brittle to have a project's VCS be switched mid-life; the easiest migration approach is to create a new project and deprecate/archive the old one, but the task for the old project keeps getting fired and just being generally sad and spamming logs.

To post a comment you must log in.
Revision history for this message
Jonathan Hartley (tartley) wrote :

A significant question I'd like to understand before I hit 'approve'. Thank you!

Revision history for this message
Daniel Manrique (roadmr) wrote :

thanks; fair to not Approve until I've figured out the stealth migrations change.

Revision history for this message
Daniel Manrique (roadmr) :
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
Revision history for this message
Jonathan Hartley (tartley) wrote :

approved!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches